-
Notifications
You must be signed in to change notification settings - Fork 11
Integrated rubocop to rubyplot and fixed some rubocop offences #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for your PR. Can you also work on #8 and setup Travis CI integration with rubocop support? |
|
Closes #8 Setup Travis CI integration with rubocop support . Also, some rubocop offences are fixed. |
…to first_branch
|
If all the changes are about rubocop you can simply push to this branch. However, please rebase your changes with the latest 'integration' branch. |
|
@v0dro Almost all the rubocop offences are fixed except some (only a little bit) Metrics related are remaining. All the rubocop changes are made into latest 'integration' branch. As well as I have removed the .travis.yml file #8 (which you have assigned to me) from this PR. I am gonna create a new PR regarding #8 . All the changes in this PR are related to only rubocop #9. |
|
Looks great! I'm currently working on a feature and will merge this branch as soon as I'm done. |
partially closes #9
Rubocop is integrated in the project and then some rubocop offences are fixed. .rubocop.yml file is added to integrate rubocop in the project.