Skip to content

Conversation

@arzoo14
Copy link
Contributor

@arzoo14 arzoo14 commented Dec 14, 2018

partially closes #9
Rubocop is integrated in the project and then some rubocop offences are fixed. .rubocop.yml file is added to integrate rubocop in the project.

@v0dro
Copy link
Member

v0dro commented Dec 15, 2018

Thank you for your PR. Can you also work on #8 and setup Travis CI integration with rubocop support?

@arzoo14
Copy link
Contributor Author

arzoo14 commented Dec 15, 2018

Closes #8 Setup Travis CI integration with rubocop support . Also, some rubocop offences are fixed.

@arzoo14
Copy link
Contributor Author

arzoo14 commented Dec 25, 2018

@v0dro I have solved some more rubocop offenses. Should I create an another PR for them? Please also review PR #20 .

@v0dro
Copy link
Member

v0dro commented Dec 25, 2018

If all the changes are about rubocop you can simply push to this branch. However, please rebase your changes with the latest 'integration' branch.

@arzoo14
Copy link
Contributor Author

arzoo14 commented Dec 25, 2018

@v0dro Almost all the rubocop offences are fixed except some (only a little bit) Metrics related are remaining. All the rubocop changes are made into latest 'integration' branch. As well as I have removed the .travis.yml file #8 (which you have assigned to me) from this PR. I am gonna create a new PR regarding #8 . All the changes in this PR are related to only rubocop #9.

@v0dro
Copy link
Member

v0dro commented Dec 26, 2018

Looks great! I'm currently working on a feature and will merge this branch as soon as I'm done.

@v0dro v0dro merged commit d104a32 into SciRuby:integration Dec 26, 2018
@arzoo14 arzoo14 deleted the first_branch branch January 1, 2019 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants